irqchip/loongson-pch-pic: Support to set IRQ type for ACPI path
authorJianmin Lv <lvjianmin@loongson.cn>
Sat, 22 Oct 2022 07:59:54 +0000 (15:59 +0800)
committerMarc Zyngier <maz@kernel.org>
Sat, 26 Nov 2022 13:05:48 +0000 (13:05 +0000)
For ACPI path, the translate callback used IRQ_TYPE_NONE and ignored
the IRQ type in fwspec->param[1]. For supporting to set type for
IRQs of the irqdomain, fwspec->param[1] should be used to get IRQ
type.

Signed-off-by: Jianmin Lv <lvjianmin@loongson.cn>
Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20221022075955.11726-4-lvjianmin@loongson.cn
drivers/irqchip/irq-loongson-pch-pic.c

index 03493cd..a26a3f5 100644 (file)
@@ -155,9 +155,6 @@ static int pch_pic_domain_translate(struct irq_domain *d,
        struct pch_pic *priv = d->host_data;
        struct device_node *of_node = to_of_node(fwspec->fwnode);
 
-       if (fwspec->param_count < 1)
-               return -EINVAL;
-
        if (of_node) {
                if (fwspec->param_count < 2)
                        return -EINVAL;
@@ -165,8 +162,14 @@ static int pch_pic_domain_translate(struct irq_domain *d,
                *hwirq = fwspec->param[0] + priv->ht_vec_base;
                *type = fwspec->param[1] & IRQ_TYPE_SENSE_MASK;
        } else {
+               if (fwspec->param_count < 1)
+                       return -EINVAL;
+
                *hwirq = fwspec->param[0] - priv->gsi_base;
-               *type = IRQ_TYPE_NONE;
+               if (fwspec->param_count > 1)
+                       *type = fwspec->param[1] & IRQ_TYPE_SENSE_MASK;
+               else
+                       *type = IRQ_TYPE_NONE;
        }
 
        return 0;