memory: tegra186-emc: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Fri, 28 Aug 2020 15:37:47 +0000 (17:37 +0200)
committerKrzysztof Kozlowski <krzk@kernel.org>
Wed, 2 Sep 2020 15:22:56 +0000 (17:22 +0200)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20200828153747.22358-2-krzk@kernel.org
drivers/memory/tegra/tegra186-emc.c

index 8478f59..fa8af17 100644 (file)
@@ -172,14 +172,8 @@ static int tegra186_emc_probe(struct platform_device *pdev)
                return -ENOMEM;
 
        emc->bpmp = tegra_bpmp_get(&pdev->dev);
-       if (IS_ERR(emc->bpmp)) {
-               err = PTR_ERR(emc->bpmp);
-
-               if (err != -EPROBE_DEFER)
-                       dev_err(&pdev->dev, "failed to get BPMP: %d\n", err);
-
-               return err;
-       }
+       if (IS_ERR(emc->bpmp))
+               return dev_err_probe(&pdev->dev, PTR_ERR(emc->bpmp), "failed to get BPMP\n");
 
        emc->clk = devm_clk_get(&pdev->dev, "emc");
        if (IS_ERR(emc->clk)) {