drm/gma500: Get rid of duplicate NULL checks
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 23 Oct 2020 18:54:00 +0000 (21:54 +0300)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 25 Jan 2021 18:05:31 +0000 (20:05 +0200)
Since GPIOs are optional we don't need to repeat checks that are done
in the GPIO API. Remove them for good.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c

index 7d012db6352b5ab0ef7e315b56f49e8115cab79b..3dab94463656f4151e188cb7cc2910ec2a523881 100644 (file)
@@ -518,11 +518,9 @@ void tc35876x_toshiba_bridge_panel_off(struct drm_device *dev)
 
        dev_dbg(&tc35876x_client->dev, "%s\n", __func__);
 
-       if (bridge_bl_enable)
-               gpiod_set_value_cansleep(bridge_bl_enable, 0);
+       gpiod_set_value_cansleep(bridge_bl_enable, 0);
 
-       if (backlight_voltage)
-               gpiod_set_value_cansleep(backlight_voltage, 0);
+       gpiod_set_value_cansleep(backlight_voltage, 0);
 }
 
 void tc35876x_toshiba_bridge_panel_on(struct drm_device *dev)
@@ -567,8 +565,7 @@ void tc35876x_toshiba_bridge_panel_on(struct drm_device *dev)
                                "i2c write failed (%d)\n", ret);
        }
 
-       if (bridge_bl_enable)
-               gpiod_set_value_cansleep(bridge_bl_enable, 1);
+       gpiod_set_value_cansleep(bridge_bl_enable, 1);
 
        tc35876x_brightness_control(dev, dev_priv->brightness_adjusted);
 }
@@ -642,20 +639,17 @@ static int tc35876x_bridge_probe(struct i2c_client *client,
        bridge_reset = devm_gpiod_get_optional(&client->dev, "bridge-reset", GPIOD_OUT_LOW);
        if (IS_ERR(bridge_reset))
                return PTR_ERR(bridge_reset);
-       if (bridge_reset)
-               gpiod_set_consumer_name(bridge_reset, "tc35876x bridge reset");
+       gpiod_set_consumer_name(bridge_reset, "tc35876x bridge reset");
 
        bridge_bl_enable = devm_gpiod_get_optional(&client->dev, "bl-en", GPIOD_OUT_LOW);
        if (IS_ERR(bridge_bl_enable))
                return PTR_ERR(bridge_bl_enable);
-       if (bridge_bl_enable)
-               gpiod_set_consumer_name(bridge_bl_enable, "tc35876x panel bl en");
+       gpiod_set_consumer_name(bridge_bl_enable, "tc35876x panel bl en");
 
        backlight_voltage = devm_gpiod_get_optional(&client->dev, "vadd", GPIOD_OUT_LOW);
        if (IS_ERR(backlight_voltage))
                return PTR_ERR(backlight_voltage);
-       if (backlight_voltage)
-               gpiod_set_consumer_name(backlight_voltage, "tc35876x panel vadd");
+       gpiod_set_consumer_name(backlight_voltage, "tc35876x panel vadd");
 
        tc35876x_client = client;