MIPS: Fix fall-through warnings for Clang
authorGustavo A. R. Silva <gustavoars@kernel.org>
Mon, 13 Sep 2021 22:17:09 +0000 (17:17 -0500)
committerGustavo A. R. Silva <gustavoars@kernel.org>
Wed, 13 Oct 2021 19:47:42 +0000 (14:47 -0500)
Fix the following fallthrough warnings:

arch/mips/alchemy/devboards/db1550.c:69:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
           case BCSR_WHOAMI_DB1550:
           ^
   arch/mips/alchemy/devboards/db1550.c:69:2: note: insert 'break;' to avoid fall-through
           case BCSR_WHOAMI_DB1550:
           ^
           break;
arch/mips/kernel/uprobes.c:176:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
           default:
           ^
   arch/mips/kernel/uprobes.c:176:2: note: insert 'break;' to avoid fall-through
           default:
           ^
           break;

This helps with the ongoing efforts to globally enable
-Wimplicit-fallthrough for Clang.

Link: https://github.com/KSPP/linux/issues/115
Link: https://lore.kernel.org/linux-mm/202109030839.t2llsvmc-lkp@intel.com/
Link: https://lore.kernel.org/linux-mm/202108271617.MHxFd8aX-lkp@intel.com/
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
arch/mips/alchemy/devboards/db1550.c
arch/mips/kernel/uprobes.c

index 752b93d..fd91d9c 100644 (file)
@@ -66,6 +66,7 @@ int __init db1550_board_setup(void)
        case BCSR_WHOAMI_PB1550_DDR:
                bcsr_init(PB1550_BCSR_PHYS_ADDR,
                          PB1550_BCSR_PHYS_ADDR + PB1550_BCSR_HEXLED_OFS);
+               break;
        case BCSR_WHOAMI_DB1550:
                break;
        default:
index 9db2a6d..6c063aa 100644 (file)
@@ -173,6 +173,7 @@ int arch_uprobe_exception_notify(struct notifier_block *self,
        case DIE_UPROBE_XOL:
                if (uprobe_post_sstep_notifier(regs))
                        return NOTIFY_STOP;
+               break;
        default:
                break;
        }