IB/hfi1: remove redundant assignment to variable ret
authorColin Ian King <colin.king@canonical.com>
Fri, 22 Nov 2019 15:48:14 +0000 (15:48 +0000)
committerJason Gunthorpe <jgg@mellanox.com>
Mon, 25 Nov 2019 14:31:47 +0000 (10:31 -0400)
The variable ret is being initialized with a value that is never
read and it is being updated later with a new value. The
initialization is redundant and can be removed.

Link: https://lore.kernel.org/r/20191122154814.87257-1-colin.king@canonical.com
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/hfi1/platform.c

index cbf7faa..36593f2 100644 (file)
@@ -634,7 +634,7 @@ static void apply_tx_lanes(struct hfi1_pportdata *ppd, u8 field_id,
                           u32 config_data, const char *message)
 {
        u8 i;
-       int ret = HCMD_SUCCESS;
+       int ret;
 
        for (i = 0; i < 4; i++) {
                ret = load_8051_config(ppd->dd, field_id, i, config_data);