Fix utils::writeToFd return type

The `writeToFd` function in `util.cc` returns `ssize_t` but the only
returned values are either `false` or `true`.

```
ssize_t writeToFd(int fd, const void* buf, size_t len) {

(...) return false;

(...) return true;
```

diff --git a/subproc.cc b/subproc.cc
index 339b5bfc6a15f48a8c1a384f0055101f4fceb211..f10a5e45e96e8d89ba74fcf453fa13bad624916e 100644 (file)
--- a/subproc.cc
+++ b/subproc.cc
@@ -383,8 +383,7 @@ static bool initParent(nsjconf_t* nsjconf, pid_t pid, int pipefd) {
                LOG_E("Couldn't initialize user namespace for pid %d", pid);
                return false;
        }
-       if (util::writeToFd(pipefd, &kSubprocDoneChar, sizeof(kSubprocDoneChar)) !=
-           sizeof(kSubprocDoneChar)) {
+       if (!util::writeToFd(pipefd, &kSubprocDoneChar, sizeof(kSubprocDoneChar))) {
                LOG_E("Couldn't signal the new process via a socketpair");
                return false;
        }

diff --git a/util.cc b/util.cc
index ddf39b8d50c281b95bec839c823f459e2b57dcd4..e271e9daeb603f0fb3acb9fc67f98166f73e8704 100644 (file)
--- a/util.cc
+++ b/util.cc
@@ -75,7 +75,7 @@ ssize_t readFromFile(const char* fname, void* buf, size_t len) {
        return ret;
 }
 
-ssize_t writeToFd(int fd, const void* buf, size_t len) {
+bool writeToFd(int fd, const void* buf, size_t len) {
        const uint8_t* charbuf = (const uint8_t*)buf;
 
        size_t writtenSz = 0;