phy: qcom-qmp-pcie: clean up status polling
authorJohan Hovold <johan+linaro@kernel.org>
Wed, 12 Oct 2022 08:49:46 +0000 (10:49 +0200)
committerVinod Koul <vkoul@kernel.org>
Fri, 28 Oct 2022 12:25:03 +0000 (17:55 +0530)
Clean up the status polling by dropping the ready bit mask which is no
longer needed since the QMP driver split.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20221012085002.24099-4-johan+linaro@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/qualcomm/phy-qcom-qmp-pcie.c

index 9b866ed..4af6b9e 100644 (file)
@@ -1966,7 +1966,7 @@ static int qmp_pcie_power_on(struct phy *phy)
        const struct qmp_phy_cfg_tables *mode_tables;
        void __iomem *pcs = qphy->pcs;
        void __iomem *status;
-       unsigned int mask, val, ready;
+       unsigned int mask, val;
        int ret;
 
        qphy_setbits(pcs, cfg->regs[QPHY_PCS_POWER_DOWN_CONTROL],
@@ -2004,9 +2004,7 @@ static int qmp_pcie_power_on(struct phy *phy)
 
        status = pcs + cfg->regs[QPHY_PCS_STATUS];
        mask = cfg->phy_status;
-       ready = 0;
-
-       ret = readl_poll_timeout(status, val, (val & mask) == ready, 10,
+       ret = readl_poll_timeout(status, val, !(val & mask), 10,
                                 PHY_INIT_COMPLETE_TIMEOUT);
        if (ret) {
                dev_err(qmp->dev, "phy initialization timed-out\n");