IB/mlx5: avoid excessive warning msgs when creating VFs on 2nd port
authorQing Huang <qing.huang@oracle.com>
Mon, 23 Jul 2018 21:15:08 +0000 (14:15 -0700)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 26 Jul 2018 22:02:28 +0000 (16:02 -0600)
When a CX5 device is configured in dual-port RoCE mode, after creating
many VFs against port 1, creating the same number of VFs against port 2
will flood kernel/syslog with something like
"mlx5_*:mlx5_ib_bind_slave_port:4266:(pid 5269): port 2 already
affiliated."

So basically, when traversing mlx5_ib_dev_list, mlx5_ib_add_slave_port()
repeatedly attempts to bind the new mpi structure to every device on the
list until it finds an unbound device.

Change the log level from warn to dbg to avoid log flooding as the warning
should be harmless.

Signed-off-by: Qing Huang <qing.huang@oracle.com>
Reviewed-by: Daniel Jurgens <danielj@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/mlx5/main.c

index a26ab69..61c78f4 100644 (file)
@@ -5380,8 +5380,8 @@ static bool mlx5_ib_bind_slave_port(struct mlx5_ib_dev *ibdev,
 
        spin_lock(&ibdev->port[port_num].mp.mpi_lock);
        if (ibdev->port[port_num].mp.mpi) {
-               mlx5_ib_warn(ibdev, "port %d already affiliated.\n",
-                            port_num + 1);
+               mlx5_ib_dbg(ibdev, "port %d already affiliated.\n",
+                           port_num + 1);
                spin_unlock(&ibdev->port[port_num].mp.mpi_lock);
                return false;
        }