platform/chrome: use sysfs_emit() instead of scnprintf()

Follow the advice in Documentation/filesystems/sysfs.rst:
show() should only use sysfs_emit() or sysfs_emit_at() when formatting
the value to be returned to user space.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Link: https://lore.kernel.org/r/202212021656040995199@zte.com.cn
[tzungbi: fixed the commit message.]
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>

diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform/chrome/cros_ec_lightbar.c
index 1674105decfb28188e9c7cb840fb1b3fee678976..376425bbd8ffb6b195f0253139d0562022005678 100644 (file)
--- a/drivers/platform/chrome/cros_ec_lightbar.c
+++ b/drivers/platform/chrome/cros_ec_lightbar.c
@@ -34,7 +34,7 @@ static ssize_t interval_msec_show(struct device *dev,
 {
        unsigned long msec = lb_interval_jiffies * 1000 / HZ;
 
-       return scnprintf(buf, PAGE_SIZE, "%lu\n", msec);
+       return sysfs_emit(buf, "%lu\n", msec);
 }
 
 static ssize_t interval_msec_store(struct device *dev,
@@ -169,7 +169,7 @@ static ssize_t version_show(struct device *dev,
        if (!get_lightbar_version(ec, &version, &flags))
                return -EIO;
 
-       return scnprintf(buf, PAGE_SIZE, "%d %d\n", version, flags);
+       return sysfs_emit(buf, "%d %d\n", version, flags);
 }
 
 static ssize_t brightness_store(struct device *dev,
@@ -302,17 +302,15 @@ static ssize_t sequence_show(struct device *dev,
 
        ret = cros_ec_cmd_xfer_status(ec->ec_dev, msg);
        if (ret < 0) {
-               ret = scnprintf(buf, PAGE_SIZE, "XFER / EC ERROR %d / %d\n",
-                               ret, msg->result);
+               ret = sysfs_emit(buf, "XFER / EC ERROR %d / %d\n", ret, msg->result);
                goto exit;
        }
 
        resp = (struct ec_response_lightbar *)msg->data;
        if (resp->get_seq.num >= ARRAY_SIZE(seqname))
-               ret = scnprintf(buf, PAGE_SIZE, "%d\n", resp->get_seq.num);
+               ret = sysfs_emit(buf, "%d\n", resp->get_seq.num);
        else
-               ret = scnprintf(buf, PAGE_SIZE, "%s\n",
-                               seqname[resp->get_seq.num]);
+               ret = sysfs_emit(buf, "%s\n", seqname[resp->get_seq.num]);
 
 exit:
        kfree(msg);
@@ -483,7 +481,7 @@ static ssize_t userspace_control_show(struct device *dev,
                                      struct device_attribute *attr,
                                      char *buf)
 {
-       return scnprintf(buf, PAGE_SIZE, "%d\n", userspace_control);
+       return sysfs_emit(buf, "%d\n", userspace_control);
 }
 
 static ssize_t userspace_control_store(struct device *dev,

diff --git a/drivers/platform/chrome/cros_ec_sysfs.c b/drivers/platform/chrome/cros_ec_sysfs.c
index f07eabcf9494cd3c85ae87cf3f502c678ce79ed0..e45e57cee3a87b20895c99e5070920c7471e8453 100644 (file)
--- a/drivers/platform/chrome/cros_ec_sysfs.c
+++ b/drivers/platform/chrome/cros_ec_sysfs.c
@@ -227,7 +227,7 @@ static ssize_t flashinfo_show(struct device *dev,
 
        resp = (struct ec_response_flash_info *)msg->data;
 
-       ret = scnprintf(buf, PAGE_SIZE,
+       ret = sysfs_emit(buf,
                        "FlashSize %d\nWriteSize %d\n"
                        "EraseSize %d\nProtectSize %d\n",
                        resp->flash_size, resp->write_block_size,
@@ -264,7 +264,7 @@ static ssize_t kb_wake_angle_show(struct device *dev,
                goto exit;
 
        resp = (struct ec_response_motion_sense *)msg->data;
-       ret = scnprintf(buf, PAGE_SIZE, "%d\n", resp->kb_wake_angle.ret);
+       ret = sysfs_emit(buf, "%d\n", resp->kb_wake_angle.ret);
 exit:
        kfree(msg);
        return ret;

diff --git a/drivers/platform/chrome/wilco_ec/sysfs.c b/drivers/platform/chrome/wilco_ec/sysfs.c
index 79a5e8fa680f2a3498ba20a174b4de4ae1272181..893c59dde32a949e394ac5244da9350d1cec0631 100644 (file)
--- a/drivers/platform/chrome/wilco_ec/sysfs.c
+++ b/drivers/platform/chrome/wilco_ec/sysfs.c
@@ -119,8 +119,7 @@ static ssize_t get_info(struct device *dev, char *buf, enum get_ec_info_op op)
        if (ret < 0)
                return ret;
 
-       return scnprintf(buf, PAGE_SIZE, "%.*s\n", (int)sizeof(resp.value),
-                        (char *)&resp.value);
+       return sysfs_emit(buf, "%.*s\n", (int)sizeof(resp.value), (char *)&resp.value);
 }
 
 static ssize_t version_show(struct device *dev, struct device_attribute *attr,