media: mtk-mdp: handle vb2_dma_contig_set_max_seg_size errors during probe
authorEizan Miyamoto <eizan@chromium.org>
Thu, 7 May 2020 10:23:44 +0000 (12:23 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Sat, 4 Jul 2020 09:58:19 +0000 (11:58 +0200)
This is a cleanup to better handle errors during MDP probe.

Signed-off-by: Eizan Miyamoto <eizan@chromium.org>
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/mtk-mdp/mtk_mdp_core.c

index aeaed2c..9b24b8d 100644 (file)
@@ -193,7 +193,11 @@ static int mtk_mdp_probe(struct platform_device *pdev)
 
        platform_set_drvdata(pdev, mdp);
 
-       vb2_dma_contig_set_max_seg_size(&pdev->dev, DMA_BIT_MASK(32));
+       ret = vb2_dma_contig_set_max_seg_size(&pdev->dev, DMA_BIT_MASK(32));
+       if (ret) {
+               dev_err(&pdev->dev, "Failed to set vb2 dma mag seg size\n");
+               goto err_m2m_register;
+       }
 
        pm_runtime_enable(dev);
        dev_dbg(dev, "mdp-%d registered successfully\n", mdp->id);