soundwire: cadence: do not extend reset delay
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Wed, 18 Aug 2021 03:01:30 +0000 (11:01 +0800)
committerVinod Koul <vkoul@kernel.org>
Mon, 23 Aug 2021 12:10:34 +0000 (17:40 +0530)
The duration of the hw_reset is defined as 4096 cycles. The Cadence IP
allows for an additional delay which doesn't seem necessary in
practice: the actual reset sequence duration is defined by the sync_go
mechanism, not by the IP itself.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20210818030130.17113-1-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/cadence_master.c

index 0b7f037..4fcc3ba 100644 (file)
@@ -1032,10 +1032,7 @@ EXPORT_SYMBOL(sdw_cdns_check_self_clearing_bits);
  */
 int sdw_cdns_exit_reset(struct sdw_cdns *cdns)
 {
-       /* program maximum length reset to be safe */
-       cdns_updatel(cdns, CDNS_MCP_CONTROL,
-                    CDNS_MCP_CONTROL_RST_DELAY,
-                    CDNS_MCP_CONTROL_RST_DELAY);
+       /* keep reset delay unchanged to 4096 cycles */
 
        /* use hardware generated reset */
        cdns_updatel(cdns, CDNS_MCP_CONTROL,