remoteproc: qcom: fix sparse warnings
authorMukesh Ojha <quic_mojha@quicinc.com>
Tue, 31 Jan 2023 16:01:06 +0000 (21:31 +0530)
committerBjorn Andersson <andersson@kernel.org>
Tue, 14 Feb 2023 16:40:33 +0000 (08:40 -0800)
This patch try to address below sparse warnings.

drivers/remoteproc/qcom_common.c:126:27: warning: restricted __le32 degrades to integer
drivers/remoteproc/qcom_common.c:133:32: warning: cast to restricted __le32
drivers/remoteproc/qcom_common.c:133:32: warning: cast from restricted __le64

Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/1675180866-16695-1-git-send-email-quic_mojha@quicinc.com
drivers/remoteproc/qcom_common.c

index 7810f91..abf66c6 100644 (file)
@@ -123,14 +123,14 @@ static int qcom_add_minidump_segments(struct rproc *rproc, struct minidump_subsy
 
        for (i = 0; i < seg_cnt; i++) {
                memcpy_fromio(&region, ptr + i, sizeof(region));
-               if (region.valid == MD_REGION_VALID) {
+               if (le32_to_cpu(region.valid) == MD_REGION_VALID) {
                        name = kstrndup(region.name, MAX_REGION_NAME_LENGTH - 1, GFP_KERNEL);
                        if (!name) {
                                iounmap(ptr);
                                return -ENOMEM;
                        }
                        da = le64_to_cpu(region.address);
-                       size = le32_to_cpu(region.size);
+                       size = le64_to_cpu(region.size);
                        rproc_coredump_add_custom_segment(rproc, da, size, NULL, name);
                }
        }