hwrng: omap3-rom - fix using wrong clk_disable() in omap_rom_rng_runtime_resume()
authorYang Yingliang <yangyingliang@huawei.com>
Sat, 14 May 2022 08:42:41 +0000 (16:42 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jun 2022 08:23:11 +0000 (10:23 +0200)
[ Upstream commit e4e62bbc6aba49a5edb3156ec65f6698ff37d228 ]

'ddata->clk' is enabled by clk_prepare_enable(), it should be disabled
by clk_disable_unprepare().

Fixes: 8d9d4bdc495f ("hwrng: omap3-rom - Use runtime PM instead of custom functions")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/char/hw_random/omap3-rom-rng.c

index e0d77fa..f06e4f9 100644 (file)
@@ -92,7 +92,7 @@ static int __maybe_unused omap_rom_rng_runtime_resume(struct device *dev)
 
        r = ddata->rom_rng_call(0, 0, RNG_GEN_PRNG_HW_INIT);
        if (r != 0) {
-               clk_disable(ddata->clk);
+               clk_disable_unprepare(ddata->clk);
                dev_err(dev, "HW init failed: %d\n", r);
 
                return -EIO;