tools: kwbimage: Check the return value of image_headersz_v1()
authorPali Rohár <pali@kernel.org>
Wed, 12 Jan 2022 17:20:42 +0000 (18:20 +0100)
committerStefan Roese <sr@denx.de>
Fri, 14 Jan 2022 10:39:16 +0000 (11:39 +0100)
Function image_headersz_v1() may return zero on fatal errors.
In this case the function already printed an error message.

Check the return value of image_headersz_v1() in kwbimage_generate(),
and exit on zero value with EXIT_FAILURE.

Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Stefan Roese <sr@denx.de>
tools/kwbimage.c

index c0f1bdac0210a681a4b2678dd6077a287f6ccbac..a5b518f60bc8208c72206a989c7c52272faabf07 100644 (file)
@@ -2029,6 +2029,10 @@ static int kwbimage_generate(struct image_tool_params *params,
 
        case 1:
                alloc_len = image_headersz_v1(NULL);
+               if (!alloc_len) {
+                       free(image_cfg);
+                       exit(EXIT_FAILURE);
+               }
                break;
 
        default: