i2c: rk3x: Adjust mask/value offset for i2c2 on rv1126
authorTim Lunn <tim@feathertop.org>
Sun, 3 Dec 2023 12:39:59 +0000 (23:39 +1100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 5 Feb 2024 20:14:33 +0000 (20:14 +0000)
[ Upstream commit 92a85b7c6262f19c65a1c115cf15f411ba65a57c ]

Rockchip RV1126 is using old style i2c controller, the i2c2
bus uses a non-sequential offset in the grf register for the
mask/value bits for this bus.

This patch fixes i2c2 bus on rv1126 SoCs.

Signed-off-by: Tim Lunn <tim@feathertop.org>
Acked-by: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/i2c/busses/i2c-rk3x.c

index 4362db7..086fdf2 100644 (file)
@@ -1295,8 +1295,12 @@ static int rk3x_i2c_probe(struct platform_device *pdev)
                        return -EINVAL;
                }
 
-               /* 27+i: write mask, 11+i: value */
-               value = BIT(27 + bus_nr) | BIT(11 + bus_nr);
+               /* rv1126 i2c2 uses non-sequential write mask 20, value 4 */
+               if (i2c->soc_data == &rv1126_soc_data && bus_nr == 2)
+                       value = BIT(20) | BIT(4);
+               else
+                       /* 27+i: write mask, 11+i: value */
+                       value = BIT(27 + bus_nr) | BIT(11 + bus_nr);
 
                ret = regmap_write(grf, i2c->soc_data->grf_offset, value);
                if (ret != 0) {