staging: r8188eu: always update the status variables
authorMartin Kaiser <martin@kaiser.cx>
Mon, 22 Aug 2022 20:13:29 +0000 (22:13 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 23 Aug 2022 13:43:40 +0000 (15:43 +0200)
Always update the status variables in rtw_led_control when we start
blinking because of no link. The code is easier to understand without
the if conditions.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220822201329.95559-4-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_led.c

index e63bcf9..c57059e 100644 (file)
@@ -225,13 +225,10 @@ void rtw_led_control(struct adapter *padapter, enum LED_CTL_MODE LedAction)
 
                cancel_delayed_work(&pLed->blink_work);
 
-               if (pLed->bLedLinkBlinkInProgress)
-                       pLed->bLedLinkBlinkInProgress = false;
-
-               if (pLed->bLedBlinkInProgress)
-                       pLed->bLedBlinkInProgress = false;
-
+               pLed->bLedLinkBlinkInProgress = false;
+               pLed->bLedBlinkInProgress = false;
                pLed->bLedNoLinkBlinkInProgress = true;
+
                pLed->CurrLedState = LED_BLINK_SLOWLY;
                if (pLed->bLedOn)
                        pLed->BlinkingLedState = RTW_LED_OFF;