ASoC: cs42l42: Validate dai_set_sysclk() frequency
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Thu, 5 Aug 2021 16:11:09 +0000 (17:11 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 5 Aug 2021 22:33:44 +0000 (23:33 +0100)
If the machine driver calls snd_set_sysclk() with an unsupported
SCLK frequency, return an error instead of letting hw_params() fail.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20210805161111.10410-6-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs42l42.c

index 6895f2f..b2ee514 100644 (file)
@@ -891,10 +891,23 @@ static int cs42l42_set_sysclk(struct snd_soc_dai *dai,
 {
        struct snd_soc_component *component = dai->component;
        struct cs42l42_private *cs42l42 = snd_soc_component_get_drvdata(component);
+       int i;
 
-       cs42l42->sclk = freq;
+       if (freq == 0) {
+               cs42l42->sclk = 0;
+               return 0;
+       }
 
-       return 0;
+       for (i = 0; i < ARRAY_SIZE(pll_ratio_table); i++) {
+               if (pll_ratio_table[i].sclk == freq) {
+                       cs42l42->sclk = freq;
+                       return 0;
+               }
+       }
+
+       dev_err(component->dev, "SCLK %u not supported\n", freq);
+
+       return -EINVAL;
 }
 
 static int cs42l42_mute_stream(struct snd_soc_dai *dai, int mute, int stream)