ext2: fix debug reference to ext2_xattr_cache
authorJan Kara <jack@suse.cz>
Tue, 17 Mar 2020 11:40:02 +0000 (12:40 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 24 Apr 2020 05:59:14 +0000 (07:59 +0200)
[ Upstream commit 32302085a8d90859c40cf1a5e8313f575d06ec75 ]

Fix a debug-only build error in ext2/xattr.c:

When building without extra debugging, (and with another patch that uses
no_printk() instead of <empty> for the ext2-xattr debug-print macros,
this build error happens:

../fs/ext2/xattr.c: In function ‘ext2_xattr_cache_insert’:
../fs/ext2/xattr.c:869:18: error: ‘ext2_xattr_cache’ undeclared (first use in
this function); did you mean ‘ext2_xattr_list’?
     atomic_read(&ext2_xattr_cache->c_entry_count));

Fix the problem by removing cached entry count from the debug message
since otherwise we'd have to export the mbcache structure just for that.

Fixes: be0726d33cb8 ("ext2: convert to mbcache2")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/ext2/xattr.c

index a54037df2c8a84d9fededbfe70e7671c97f3b5dd..c8679b58356179aef2017b06bd3281ff39a99c1b 100644 (file)
@@ -836,8 +836,7 @@ ext2_xattr_cache_insert(struct mb_cache *cache, struct buffer_head *bh)
        error = mb_cache_entry_create(cache, GFP_NOFS, hash, bh->b_blocknr, 1);
        if (error) {
                if (error == -EBUSY) {
-                       ea_bdebug(bh, "already in cache (%d cache entries)",
-                               atomic_read(&ext2_xattr_cache->c_entry_count));
+                       ea_bdebug(bh, "already in cache");
                        error = 0;
                }
        } else