RDMA/bnxt_re: Remove a redundant 'memset'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 8 Mar 2020 06:54:42 +0000 (07:54 +0100)
committerJason Gunthorpe <jgg@mellanox.com>
Tue, 10 Mar 2020 17:33:21 +0000 (14:33 -0300)
'wqe' is already zeroed at the top of the 'while' loop, just a few lines
below, and is not used outside of the loop.

So there is no need to zero it again, or for the variable to be declared
outside the loop.

Link: https://lore.kernel.org/r/20200308065442.5415-1-christophe.jaillet@wanadoo.fr
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/bnxt_re/ib_verbs.c

index 47b0b50..95f6d49 100644 (file)
@@ -2470,15 +2470,12 @@ static int bnxt_re_post_send_shadow_qp(struct bnxt_re_dev *rdev,
                                       struct bnxt_re_qp *qp,
                                       const struct ib_send_wr *wr)
 {
-       struct bnxt_qplib_swqe wqe;
        int rc = 0, payload_sz = 0;
        unsigned long flags;
 
        spin_lock_irqsave(&qp->sq_lock, flags);
-       memset(&wqe, 0, sizeof(wqe));
        while (wr) {
-               /* House keeping */
-               memset(&wqe, 0, sizeof(wqe));
+               struct bnxt_qplib_swqe wqe = {};
 
                /* Common */
                wqe.num_sge = wr->num_sge;