staging: rtl8192u: Using comparison to true is error prone
authorJohn Oldman <john.oldman@polehill.co.uk>
Sat, 16 May 2020 16:33:27 +0000 (17:33 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 May 2020 14:13:40 +0000 (16:13 +0200)
fix below issue reported by checkpatch:

CHECK: Using comparison to true is error prone
CHECK: Using comparison to false is error prone

Signed-off-by: John Oldman <john.oldman@polehill.co.uk>
Link: https://lore.kernel.org/r/20200516163327.9197-1-john.oldman@polehill.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c

index 0ee054d..63a561a 100644 (file)
@@ -372,9 +372,9 @@ ieee80211_query_HTCapShortGI(struct ieee80211_device *ieee, struct cb_desc *tcb_
                return;
        }
 
-       if ((pHTInfo->bCurBW40MHz == true) && pHTInfo->bCurShortGI40MHz)
+       if (pHTInfo->bCurBW40MHz && pHTInfo->bCurShortGI40MHz)
                tcb_desc->bUseShortGI = true;
-       else if ((pHTInfo->bCurBW40MHz == false) && pHTInfo->bCurShortGI20MHz)
+       else if (!pHTInfo->bCurBW40MHz && pHTInfo->bCurShortGI20MHz)
                tcb_desc->bUseShortGI = true;
 }