mesh: Cleanup D-Bus method returns with empty result
authorMichał Lowas-Rzechonek <michal.lowas-rzechonek@silvair.com>
Thu, 4 Jul 2019 12:33:35 +0000 (14:33 +0200)
committerAnupam Roy <anupam.r@samsung.com>
Tue, 17 Dec 2019 15:21:07 +0000 (20:51 +0530)
Change-Id: I891ea4f6d3587383152b5a29d63db098b9c024dc
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
mesh/node.c

index 93dccf4..209bbbe 100644 (file)
@@ -1757,7 +1757,6 @@ static struct l_dbus_message *send_call(struct l_dbus *dbus,
        uint16_t dst, app_idx, src;
        uint8_t *data;
        uint32_t len;
-       struct l_dbus_message *reply;
 
        l_debug("Send");
 
@@ -1786,10 +1785,7 @@ static struct l_dbus_message *send_call(struct l_dbus *dbus,
                                mesh_net_get_default_ttl(node->net), data, len))
                return dbus_error(msg, MESH_ERROR_FAILED, NULL);
 
-       reply = l_dbus_message_new_method_return(msg);
-       l_dbus_message_set_arguments(reply, "");
-
-       return reply;
+       return l_dbus_message_new_method_return(msg);
 }
 
 static struct l_dbus_message *publish_call(struct l_dbus *dbus,
@@ -1803,7 +1799,6 @@ static struct l_dbus_message *publish_call(struct l_dbus *dbus,
        struct node_element *ele;
        uint8_t *data;
        uint32_t len;
-       struct l_dbus_message *reply;
        int result;
 
        l_debug("Publish");
@@ -1835,10 +1830,7 @@ static struct l_dbus_message *publish_call(struct l_dbus *dbus,
        if (result != MESH_ERROR_NONE)
                return dbus_error(msg, result, NULL);
 
-       reply = l_dbus_message_new_method_return(msg);
-       l_dbus_message_set_arguments(reply, "");
-
-       return reply;
+       return l_dbus_message_new_method_return(msg);
 }
 
 static struct l_dbus_message *vendor_publish_call(struct l_dbus *dbus,
@@ -1854,7 +1846,6 @@ static struct l_dbus_message *vendor_publish_call(struct l_dbus *dbus,
        struct node_element *ele;
        uint8_t *data = NULL;
        uint32_t len;
-       struct l_dbus_message *reply;
        int result;
 
        l_debug("Publish");
@@ -1887,10 +1878,7 @@ static struct l_dbus_message *vendor_publish_call(struct l_dbus *dbus,
        if (result != MESH_ERROR_NONE)
                return dbus_error(msg, result, NULL);
 
-       reply = l_dbus_message_new_method_return(msg);
-       l_dbus_message_set_arguments(reply, "");
-
-       return reply;
+       return  l_dbus_message_new_method_return(msg);
 }
 
 static void setup_node_interface(struct l_dbus_interface *iface)