basevideoencoder: handle failures in start() and stop()

diff --git a/omx/gstbasevideoencoder.c b/omx/gstbasevideoencoder.c
index b772512..c14d7a1 100644 (file)
--- a/omx/gstbasevideoencoder.c
+++ b/omx/gstbasevideoencoder.c
@@ -899,7 +899,8 @@ gst_base_video_encoder_change_state (GstElement * element,
     case GST_STATE_CHANGE_READY_TO_PAUSED:
       gst_base_video_encoder_reset (base_video_encoder);
       if (base_video_encoder_class->start) {
-        base_video_encoder_class->start (base_video_encoder);
+        if (!base_video_encoder_class->start (base_video_encoder))
+          goto start_error;
       }
       break;
     default:
@@ -912,7 +913,8 @@ gst_base_video_encoder_change_state (GstElement * element,
     case GST_STATE_CHANGE_PAUSED_TO_READY:
       gst_base_video_encoder_reset (base_video_encoder);
       if (base_video_encoder_class->stop) {
-        base_video_encoder_class->stop (base_video_encoder);
+        if (!base_video_encoder_class->stop (base_video_encoder))
+          goto stop_error;
       }
       break;
     default:
@@ -920,6 +922,14 @@ gst_base_video_encoder_change_state (GstElement * element,
   }
 
   return ret;
+
+start_error:
+  GST_WARNING_OBJECT (base_video_encoder, "failed to start");
+  return GST_STATE_CHANGE_FAILURE;
+
+stop_error:
+  GST_WARNING_OBJECT (base_video_encoder, "failed to stop");
+  return GST_STATE_CHANGE_FAILURE;
 }
 
 /**