mfd: janz-cmodio: Use DEVICE_ATTR_RO macro
authorZhen Lei <thunder.leizhen@huawei.com>
Wed, 2 Jun 2021 11:43:37 +0000 (19:43 +0800)
committerLee Jones <lee.jones@linaro.org>
Tue, 15 Jun 2021 12:14:23 +0000 (13:14 +0100)
Use DEVICE_ATTR_RO macro helper instead of plain DEVICE_ATTR, which makes
the code a bit shorter and easier to read.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/janz-cmodio.c

index 3df4e9a..70eba4c 100644 (file)
@@ -149,15 +149,15 @@ static int cmodio_probe_submodules(struct cmodio_device *priv)
  * SYSFS Attributes
  */
 
-static ssize_t mbus_show(struct device *dev, struct device_attribute *attr,
-                        char *buf)
+static ssize_t modulbus_number_show(struct device *dev,
+                                   struct device_attribute *attr, char *buf)
 {
        struct cmodio_device *priv = dev_get_drvdata(dev);
 
        return snprintf(buf, PAGE_SIZE, "%x\n", priv->hex);
 }
 
-static DEVICE_ATTR(modulbus_number, S_IRUGO, mbus_show, NULL);
+static DEVICE_ATTR_RO(modulbus_number);
 
 static struct attribute *cmodio_sysfs_attrs[] = {
        &dev_attr_modulbus_number.attr,