vaapisink: drop unused "synchronous" mode.
authorGwenole Beauchesne <gwenole.beauchesne@intel.com>
Wed, 30 Jul 2014 14:47:20 +0000 (16:47 +0200)
committerGwenole Beauchesne <gwenole.beauchesne@intel.com>
Wed, 30 Jul 2014 16:35:31 +0000 (18:35 +0200)
Support for X11 "synchronous" mode was never implemented, and was only
to be useful for debugging. Drop that altogether, that's not going to
be useful in practice.

https://bugzilla.gnome.org/show_bug.cgi?id=733985

gst/vaapi/gstvaapisink.c
gst/vaapi/gstvaapisink.h

index 49146df..7f6f2e5 100644 (file)
@@ -126,7 +126,6 @@ enum {
     PROP_DISPLAY_TYPE,
     PROP_DISPLAY_NAME,
     PROP_FULLSCREEN,
-    PROP_SYNCHRONOUS,
     PROP_ROTATION,
     PROP_FORCE_ASPECT_RATIO,
     PROP_VIEW_ID,
@@ -1101,9 +1100,6 @@ gst_vaapisink_set_property(
     case PROP_FULLSCREEN:
         sink->fullscreen = g_value_get_boolean(value);
         break;
-    case PROP_SYNCHRONOUS:
-        sink->synchronous = g_value_get_boolean(value);
-        break;
     case PROP_VIEW_ID:
         sink->view_id = g_value_get_int(value);
         break;
@@ -1139,9 +1135,6 @@ gst_vaapisink_get_property(
     case PROP_FULLSCREEN:
         g_value_set_boolean(value, sink->fullscreen);
         break;
-    case PROP_SYNCHRONOUS:
-        g_value_set_boolean(value, sink->synchronous);
-        break;
     case PROP_VIEW_ID:
         g_value_set_int(value, sink->view_id);
         break;
@@ -1243,21 +1236,6 @@ gst_vaapisink_class_init(GstVaapiSinkClass *klass)
                               G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
 
     /**
-     * GstVaapiSink:synchronous:
-     *
-     * When enabled, runs the X display in synchronous mode. Note that
-     * this is used only for debugging.
-     */
-    g_object_class_install_property
-        (object_class,
-         PROP_SYNCHRONOUS,
-         g_param_spec_boolean("synchronous",
-                              "Synchronous mode",
-                              "Toggles X display synchronous mode",
-                              FALSE,
-                              G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
-
-    /**
      * GstVaapiSink:rotation:
      *
      * The VA display rotation mode, expressed as a #GstVaapiRotation.
@@ -1326,7 +1304,6 @@ gst_vaapisink_init(GstVaapiSink *sink)
     sink->handle_events  = TRUE;
     sink->foreign_window = FALSE;
     sink->fullscreen     = FALSE;
-    sink->synchronous    = FALSE;
     sink->rotation       = DEFAULT_ROTATION;
     sink->rotation_req   = DEFAULT_ROTATION;
     sink->use_overlay    = FALSE;
index b286530..5dc5101 100644 (file)
@@ -82,7 +82,6 @@ struct _GstVaapiSink {
     guint               handle_events   : 1;
     guint               foreign_window  : 1;
     guint               fullscreen      : 1;
-    guint               synchronous     : 1;
     guint               use_overlay     : 1;
     guint               use_rotation    : 1;
     guint               keep_aspect     : 1;