i2c: bcm2835: Set clock-stretch timeout to 35ms
authorPhil Elwell <phil@raspberrypi.org>
Fri, 12 Jul 2019 14:38:35 +0000 (15:38 +0100)
committerpopcornmix <popcornmix@gmail.com>
Fri, 12 Jul 2019 16:08:50 +0000 (17:08 +0100)
The BCM2835 I2C blocks have a register to set the clock-stretch
timeout - how long the device is allowed to hold SCL low - in bus
cycles. The current driver doesn't write to the register, therefore
the default value of 64 cycles is being used for all devices.

Set the timeout to the value recommended for SMBus - 35ms.

See: https://github.com/raspberrypi/linux/issues/3064

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
drivers/i2c/busses/i2c-bcm2835.c

index 79d0628..beaa63c 100644 (file)
@@ -194,6 +194,7 @@ static int clk_bcm2835_i2c_set_rate(struct clk_hw *hw, unsigned long rate,
 {
        struct clk_bcm2835_i2c *div = to_clk_bcm2835_i2c(hw);
        u32 redl, fedl;
+       u32 clk_tout;
        u32 divider = clk_bcm2835_i2c_calc_divider(rate, parent_rate);
 
        if (divider == -EINVAL)
@@ -217,6 +218,17 @@ static int clk_bcm2835_i2c_set_rate(struct clk_hw *hw, unsigned long rate,
        bcm2835_i2c_writel(div->i2c_dev, BCM2835_I2C_DEL,
                           (fedl << BCM2835_I2C_FEDL_SHIFT) |
                           (redl << BCM2835_I2C_REDL_SHIFT));
+
+       /*
+        * Set the clock stretch timeout to the SMBUs-recommended 35ms.
+        */
+       if (rate > 0xffff*1000/35)
+           clk_tout = 0xffff;
+       else
+           clk_tout = 35*rate/1000;
+
+       bcm2835_i2c_writel(div->i2c_dev, BCM2835_I2C_CLKT, clk_tout);
+
        return 0;
 }