cxl: Reduce scope for the variable “mm” in cxllib_get_PE_attributes()
authorMarkus Elfring <elfring@users.sourceforge.net>
Thu, 10 Dec 2020 13:14:07 +0000 (14:14 +0100)
committerMichael Ellerman <mpe@ellerman.id.au>
Sun, 31 Jan 2021 11:35:50 +0000 (22:35 +1100)
A local variable was used only within an if branch.
Thus move the definition for the variable “mm” into the corresponding
code block.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/5cee2b25-71e0-15aa-fba6-12211b8308aa@web.de
drivers/misc/cxl/cxllib.c

index 2a1783f..53b9198 100644 (file)
@@ -170,8 +170,6 @@ int cxllib_get_PE_attributes(struct task_struct *task,
                             unsigned long translation_mode,
                             struct cxllib_pe_attributes *attr)
 {
-       struct mm_struct *mm = NULL;
-
        if (translation_mode != CXL_TRANSLATED_MODE &&
                translation_mode != CXL_REAL_MODE)
                return -EINVAL;
@@ -182,7 +180,7 @@ int cxllib_get_PE_attributes(struct task_struct *task,
                                true);
        attr->lpid = mfspr(SPRN_LPID);
        if (task) {
-               mm = get_task_mm(task);
+               struct mm_struct *mm = get_task_mm(task);
                if (mm == NULL)
                        return -EINVAL;
                /*