NFSD: Replace READ* macros in nfsd4_decode_write()
authorChuck Lever <chuck.lever@oracle.com>
Tue, 3 Nov 2020 19:44:28 +0000 (14:44 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 30 Nov 2020 19:46:40 +0000 (14:46 -0500)
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4xdr.c

index 4ec08eb..8e960cd 100644 (file)
@@ -1396,22 +1396,23 @@ nfsd4_decode_verify(struct nfsd4_compoundargs *argp, struct nfsd4_verify *verify
 static __be32
 nfsd4_decode_write(struct nfsd4_compoundargs *argp, struct nfsd4_write *write)
 {
-       DECODE_HEAD;
+       __be32 status;
 
-       status = nfsd4_decode_stateid(argp, &write->wr_stateid);
+       status = nfsd4_decode_stateid4(argp, &write->wr_stateid);
        if (status)
                return status;
-       READ_BUF(16);
-       p = xdr_decode_hyper(p, &write->wr_offset);
-       write->wr_stable_how = be32_to_cpup(p++);
+       if (xdr_stream_decode_u64(argp->xdr, &write->wr_offset) < 0)
+               return nfserr_bad_xdr;
+       if (xdr_stream_decode_u32(argp->xdr, &write->wr_stable_how) < 0)
+               return nfserr_bad_xdr;
        if (write->wr_stable_how > NFS_FILE_SYNC)
-               goto xdr_error;
-       write->wr_buflen = be32_to_cpup(p++);
-
+               return nfserr_bad_xdr;
+       if (xdr_stream_decode_u32(argp->xdr, &write->wr_buflen) < 0)
+               return nfserr_bad_xdr;
        if (!xdr_stream_subsegment(argp->xdr, &write->wr_payload, write->wr_buflen))
-               goto xdr_error;
+               return nfserr_bad_xdr;
 
-       DECODE_TAIL;
+       return nfs_ok;
 }
 
 static __be32