Fix testing with nss-crypt.

A glibc master build with --enable-nss-crypt using the NSS
crypto libraries fails during make check with the following error:

<command-line>:0:0: error: "USE_CRYPT" redefined [-Werror]
<command-line>:0:0: note: this is the location of the previous
definition

This is caused by commit 36975e8e7ea227f7006abdc722ecfefe2079429b
by H.J. Lu which replaces all = with +=. The fix is to undefine
USE_CRYPT before defining it to zero.

Committed as an obvious fix. Fixes the build issue on x86_64 with
no regressions.

Signed-off-by: Carlos O'Donell <carlos@redhat.com>

diff --git a/ChangeLog b/ChangeLog
index f560b2a832593f3116781b508cc7842db6ca0c03..22df17b671074697e516f8fcea5b38d4be9db8ba 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2017-12-12  Carlos O'Donell <carlos@redhat.com>
+
+       * elf/Makefile [$(nss-crypt)$(static-nss-crypt) == yesno]
+       (CFLAGS-tst-linkall-static.c): Undefine USE_CRYPT first.
+
 2017-12-12  Joseph Myers  <joseph@codesourcery.com>
 
        * soft-fp/fmadf4.c: Move to ....

diff --git a/elf/Makefile b/elf/Makefile
index 7b8f325ccf59f1f6e364a48f57788cfd32175662..856355507966c1a3f105d300990223615b044c10 100644 (file)
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -391,7 +391,7 @@ CFLAGS-tst-linkall-static.c += -DUSE_CRYPT=1
 # library, then we exclude the use of crypt functions in the test.
 # We similarly exclude libcrypt.a from the static link (see below).
 ifeq (yesno,$(nss-crypt)$(static-nss-crypt))
-CFLAGS-tst-linkall-static.c += -DUSE_CRYPT=0
+CFLAGS-tst-linkall-static.c += -UUSE_CRYPT -DUSE_CRYPT=0
 endif
 
 include ../Rules