[custom-app] svace: added missing try-catch accepted/tizen/unified/20210210.052156 submit/tizen/20210209.084149
authorParichay Kapoor <pk.kapoor@samsung.com>
Tue, 9 Feb 2021 04:02:38 +0000 (13:02 +0900)
committerMyungJoo Ham <myungjoo.ham@samsung.com>
Tue, 9 Feb 2021 08:42:37 +0000 (17:42 +0900)
Added missing try-catch reported by svace for the custom tizen application

**Self evaluation:**
1. Build test: [x]Passed [ ]Failed [ ]Skipped
2. Run test: [x]Passed [ ]Failed [ ]Skipped

Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
Applications/Custom/LayerClient/jni/main.cpp

index 584446ce1b404996b5c5bba01e4b0b0cfde131d3..6dc6d86221878f1d525bad5389ca716d7a4430c8 100644 (file)
@@ -75,8 +75,14 @@ static int ini_model_run(const std::string &ini_path) {
     return 1;
   }
 
-  std::shared_ptr<ml::train::Dataset> dataset = ml::train::createDataset(
-    ml::train::DatasetType::GENERATOR, constant_generator_cb, nullptr, nullptr);
+  std::shared_ptr<ml::train::Dataset> dataset;
+  try {
+    dataset = ml::train::createDataset(ml::train::DatasetType::GENERATOR,
+                                       constant_generator_cb, nullptr, nullptr);
+  } catch (...) {
+    std::cerr << "creating dataset failed";
+    return 1;
+  }
 
   if (model->setDataset(dataset) != 0) {
     std::cerr << "failed to set datatset";
@@ -111,24 +117,35 @@ int api_model_run() {
   auto model = ml::train::createModel(ml::train::ModelType::NEURAL_NET,
                                       {"loss=cross", "batch_size=10"});
 
-  std::shared_ptr<ml::train::Dataset> dataset = ml::train::createDataset(
-    ml::train::DatasetType::GENERATOR, constant_generator_cb, nullptr, nullptr);
+  std::shared_ptr<ml::train::Dataset> dataset;
+  std::shared_ptr<ml::train::Optimizer> optimizer;
+  std::vector<std::shared_ptr<ml::train::Layer>> layers;
+
+  try {
+    dataset = ml::train::createDataset(ml::train::DatasetType::GENERATOR,
+                                       constant_generator_cb, nullptr, nullptr);
+  } catch (...) {
+    std::cerr << "creating dataset failed";
+    return 1;
+  }
 
   if (model->setDataset(dataset) != 0) {
     std::cerr << "failed to set datatset";
     return 1;
   }
 
-  std::shared_ptr<ml::train::Optimizer> optimizer =
-    ml::train::optimizer::SGD({"learning_rate=0.1"});
+  try {
+    optimizer = ml::train::optimizer::SGD({"learning_rate=0.1"});
+  } catch (...) {
+    std::cerr << "creating optimizer failed";
+    return 1;
+  }
 
   if (model->setOptimizer(optimizer) != 0) {
     std::cerr << "failed to set optimizer";
     return 1;
   }
 
-  std::vector<std::shared_ptr<ml::train::Layer>> layers;
-
   try {
     /// creating array of layers same as in `custom_layer_client.ini`
     layers = std::vector<std::shared_ptr<ml::train::Layer>>{