libs: decoder: h265: remove spurious code
authorVíctor Manuel Jáquez Leal <vjaquez@igalia.com>
Wed, 9 Aug 2017 17:06:59 +0000 (19:06 +0200)
committerVíctor Manuel Jáquez Leal <vjaquez@igalia.com>
Wed, 9 Aug 2017 17:06:59 +0000 (19:06 +0200)
Coverity scan:

Logically dead code: The indicated dead code may have performed some
action; that action will never occur.

By using pointer arithmetic is impossible to get NULL.

gst-libs/gst/vaapi/gstvaapidecoder_h265.c

index a1c856d3531874a6156433fdb9392f6c786fb7ba..9d2fa6ee1767f136957a89cfcebc9718e9271c64 100644 (file)
@@ -2666,14 +2666,9 @@ gst_vaapi_decoder_h265_decode_codec_data (GstVaapiDecoder *
   num_nal_arrays = buf[22];
   ofs = 23;
   for (i = 0; i < num_nal_arrays; i++) {
-    const guchar *data;
-
     if (ofs + 1 > buf_size)
       return GST_VAAPI_DECODER_STATUS_ERROR_NO_DATA;
-    data = buf + ofs + 1;
-    if (!data)
-      return GST_VAAPI_DECODER_STATUS_ERROR_NO_DATA;
-    num_nals = GST_READ_UINT16_BE (data);
+    num_nals = GST_READ_UINT16_BE (buf + ofs + 1);
     /* the max number of nals is GST_H265_MAX_PPS_COUNT (64) */
     if (num_nals > 64)
       return GST_VAAPI_DECODER_STATUS_ERROR_BITSTREAM_PARSER;