rcu: in_irq() cleanup

This commit replaces the obsolete and ambiguous macro in_irq() with its
shiny new in_hardirq() equivalent.

Signed-off-by: Changbin Du <changbin.du@gmail.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>

diff --git a/include/linux/rcutiny.h b/include/linux/rcutiny.h
index 9be015305f9f9ca2da97601756bf43f33c4c33bd..858f4d429946d34de9511fbdc7baedcca3cc51b3 100644 (file)
--- a/include/linux/rcutiny.h
+++ b/include/linux/rcutiny.h
@@ -85,7 +85,7 @@ static inline void rcu_irq_enter_irqson(void) { }
 static inline void rcu_irq_exit(void) { }
 static inline void rcu_irq_exit_check_preempt(void) { }
 #define rcu_is_idle_cpu(cpu) \
-       (is_idle_task(current) && !in_nmi() && !in_irq() && !in_serving_softirq())
+       (is_idle_task(current) && !in_nmi() && !in_hardirq() && !in_serving_softirq())
 static inline void exit_rcu(void) { }
 static inline bool rcu_preempt_need_deferred_qs(struct task_struct *t)
 {

diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index ef8d36f580fc358614dfbcd95264c454fda09feb..f0f19dc7f19ecd88d5c79d3ac3cf8a968e2b5b34 100644 (file)
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -1467,7 +1467,7 @@ static void rcu_gp_kthread_wake(void)
 {
        struct task_struct *t = READ_ONCE(rcu_state.gp_kthread);
 
-       if ((current == t && !in_irq() && !in_serving_softirq()) ||
+       if ((current == t && !in_hardirq() && !in_serving_softirq()) ||
            !READ_ONCE(rcu_state.gp_flags) || !t)
                return;
        WRITE_ONCE(rcu_state.gp_wake_time, jiffies);

diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
index 5199559fbbf0c0922a03c93c461c93156ad6e060..599084c4c21fd1b11b6a6030392b456992026bc5 100644 (file)
--- a/kernel/rcu/tree_plugin.h
+++ b/kernel/rcu/tree_plugin.h
@@ -642,7 +642,7 @@ static void rcu_read_unlock_special(struct task_struct *t)
                           (IS_ENABLED(CONFIG_RCU_BOOST) && irqs_were_disabled &&
                            t->rcu_blocked_node);
                // Need to defer quiescent state until everything is enabled.
-               if (use_softirq && (in_irq() || (expboost && !irqs_were_disabled))) {
+               if (use_softirq && (in_hardirq() || (expboost && !irqs_were_disabled))) {
                        // Using softirq, safe to awaken, and either the
                        // wakeup is free or there is either an expedited
                        // GP in flight or a potential need to deboost.