fimc-is: Do not skip enabling enabled regulators
authorMarek Szyprowski <m.szyprowski@samsung.com>
Thu, 6 Aug 2015 08:09:24 +0000 (10:09 +0200)
committerMarek Szyprowski <m.szyprowski@samsung.com>
Fri, 27 Apr 2018 08:25:07 +0000 (10:25 +0200)
Regulators have proper on/off refcount, so use it instead of strange
is_enabled() based logic.

Change-Id: I6e23a5a6c3576d50581cb887f57a51897cdd86eb
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
drivers/media/platform/exynos/fimc-is/setup-fimc-is-sensor.c

index f2289f5afd3b026f9752375bd8053597fbcec50a..4c48ff1b08ca6736f4d4fbbfda3388c91e47c87d 100644 (file)
@@ -103,13 +103,6 @@ static int exynos_fimc_is_sensor_pin_control(struct platform_device *pdev,
                                        pr_err("%s : regulator_set_voltage(%d) fail\n", __func__, ret);
                                }
                        }
-
-                       if (regulator_is_enabled(regulator)) {
-                               pr_warning("%s regulator is already enabled\n", name);
-                               regulator_put(regulator);
-                               return 0;
-                       }
-
                        ret = regulator_enable(regulator);
                        if (ret) {
                                pr_err("%s : regulator_enable(%s) fail\n", __func__, name);
@@ -129,13 +122,6 @@ static int exynos_fimc_is_sensor_pin_control(struct platform_device *pdev,
                                pr_err("%s : regulator_get(%s) fail\n", __func__, name);
                                return PTR_ERR(regulator);
                        }
-
-                       if (!regulator_is_enabled(regulator)) {
-                               pr_warning("%s regulator is already disabled\n", name);
-                               regulator_put(regulator);
-                               return 0;
-                       }
-
                        ret = regulator_disable(regulator);
                        if (ret) {
                                pr_err("%s : regulator_disable(%s) fail\n", __func__, name);