Make buttons on javascript popup to be translatable
authorjunghwan.kang <junghwan.kang@samsung.com>
Mon, 23 Sep 2013 09:29:19 +0000 (18:29 +0900)
committerbunam.jeon <bunam.jeon@samsung.com>
Thu, 26 Sep 2013 03:13:43 +0000 (12:13 +0900)
[Title] Make buttons on javascript popup to be translatable
[Issue#] P130918-03829
[Problem] Texts on buttons cannot be changed when language of system.
[Cause] the property for buttons are not allowed before
[Solution] Give property to be changable

Change-Id: I2c7f2e3d8873cbb1b80be3f56e2395b521330ce9

Source/WebKit2/UIProcess/API/efl/tizen/JavaScriptPopup.cpp

index bbf779b..ce3416e 100755 (executable)
@@ -151,8 +151,7 @@ bool JavaScriptPopup::alert(const char* message)
 #endif
 
     Evas_Object* okButton = elm_button_add(m_popup);
-    // FIXME: Need to apply i18n for the button label
-    elm_object_text_set(okButton, "OK");
+    elm_object_domain_translatable_part_text_set(okButton, NULL, "sys_string", "IDS_COM_SK_OK");
     elm_object_part_content_set(m_popup, "button1", okButton);
     evas_object_smart_callback_add(okButton, "clicked", alertResponseCallback, this);
 
@@ -212,18 +211,16 @@ bool JavaScriptPopup::confirm(const char* message)
     }
 #endif
 
-    Evas_Object* okButton = elm_button_add(m_popup);
-    // FIXME: Need to apply i18n for the button label
-    elm_object_text_set(okButton, "OK");
-    elm_object_part_content_set(m_popup, "button1", okButton);
-    evas_object_smart_callback_add(okButton, "clicked", confirmOkCallback, this);
-
     Evas_Object* cancelButton = elm_button_add(m_popup);
-    // FIXME: Need to apply i18n for the button label
-    elm_object_text_set(cancelButton, "Cancel");
-    elm_object_part_content_set(m_popup, "button2", cancelButton);
+    elm_object_domain_translatable_part_text_set(cancelButton, NULL, "sys_string", "IDS_COM_SK_CANCEL");
+    elm_object_part_content_set(m_popup, "button1", cancelButton);
     evas_object_smart_callback_add(cancelButton, "clicked", confirmCancelCallback, this);
 
+    Evas_Object* okButton = elm_button_add(m_popup);
+    elm_object_domain_translatable_part_text_set(okButton, NULL, "sys_string", "IDS_COM_SK_OK");
+    elm_object_part_content_set(m_popup, "button2", okButton);
+    evas_object_smart_callback_add(okButton, "clicked", confirmOkCallback, this);
+
     evas_object_show(m_popup);
 
     return true;
@@ -316,18 +313,16 @@ bool JavaScriptPopup::prompt(const char* message, const char* defaultValue)
     }
 #endif
 
-    Evas_Object* okButton = elm_button_add(m_popup);
-    // FIXME: Need to apply i18n for the button label
-    elm_object_text_set(okButton, "OK");
-    elm_object_part_content_set(m_popup, "button1", okButton);
-    evas_object_smart_callback_add(okButton, "clicked", promptOkCallback, this);
-
     Evas_Object* cancelButton = elm_button_add(m_popup);
-    // FIXME: Need to apply i18n for the button label
-    elm_object_text_set(cancelButton, "Cancel");
-    elm_object_part_content_set(m_popup, "button2", cancelButton);
+    elm_object_domain_translatable_part_text_set(cancelButton, NULL, "sys_string", "IDS_COM_SK_CANCEL");
+    elm_object_part_content_set(m_popup, "button1", cancelButton);
     evas_object_smart_callback_add(cancelButton, "clicked", promptCancelCallback, this);
 
+    Evas_Object* okButton = elm_button_add(m_popup);
+    elm_object_domain_translatable_part_text_set(okButton, NULL, "sys_string", "IDS_COM_SK_OK");
+    elm_object_part_content_set(m_popup, "button2", okButton);
+    evas_object_smart_callback_add(okButton, "clicked", promptOkCallback, this);
+
     evas_object_show(m_popup);
     return true;
 }