Platform: OLPC: Remove dcon_rdev from olpc_ec_priv
authorLubomir Rintel <lkundrak@v3.sk>
Tue, 26 Jan 2021 07:37:39 +0000 (08:37 +0100)
committerHans de Goede <hdegoede@redhat.com>
Tue, 2 Feb 2021 19:51:29 +0000 (20:51 +0100)
It is not needed. Use a local variable instead.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Link: https://lore.kernel.org/r/20210126073740.10232-3-lkundrak@v3.sk
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/olpc/olpc-ec.c

index 2db7113..3c852d5 100644 (file)
@@ -37,7 +37,6 @@ struct olpc_ec_priv {
        struct mutex cmd_lock;
 
        /* DCON regulator */
-       struct regulator_dev *dcon_rdev;
        bool dcon_enabled;
 
        /* Pending EC commands */
@@ -405,6 +404,7 @@ static int olpc_ec_probe(struct platform_device *pdev)
 {
        struct olpc_ec_priv *ec;
        struct regulator_config config = { };
+       struct regulator_dev *regulator;
        int err;
 
        if (!ec_driver)
@@ -432,11 +432,10 @@ static int olpc_ec_probe(struct platform_device *pdev)
        config.dev = pdev->dev.parent;
        config.driver_data = ec;
        ec->dcon_enabled = true;
-       ec->dcon_rdev = devm_regulator_register(&pdev->dev, &dcon_desc,
-                                                               &config);
-       if (IS_ERR(ec->dcon_rdev)) {
+       regulator = devm_regulator_register(&pdev->dev, &dcon_desc, &config);
+       if (IS_ERR(regulator)) {
                dev_err(&pdev->dev, "failed to register DCON regulator\n");
-               err = PTR_ERR(ec->dcon_rdev);
+               err = PTR_ERR(regulator);
                goto error;
        }