projects / platform / upstream / dotnet / runtime.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 0b96651)
Enable skipped CodeDom tests on Android (#56581)
authorSteve Pfister <steveisok@users.noreply.github.com>
Fri, 30 Jul 2021 11:59:52 +0000 (07:59 -0400)
committerGitHub <noreply@github.com>
Fri, 30 Jul 2021 11:59:52 +0000 (07:59 -0400)
Some C# and VB code generation tests were being skipped due to UseSystemResourceKeys being enabled. It no longer is.

Fixes #50879

src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CSharpCodeGenerationTests.cs patch | blob | history
src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/VBCodeGenerationTests.cs patch | blob | history

diff --git a/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CSharpCodeGenerationTests.cs b/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CSharpCodeGenerationTests.cs
index 54b9b6aa1e0998d334c3cbebe58bd83e68b99003..b727fcac191dd06c25bb2d656211b864dc3d3035 100644 (file)
--- a/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CSharpCodeGenerationTests.cs
+++ b/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CSharpCodeGenerationTests.cs
@@ -614,7 +614,6 @@ namespace System.CodeDom.Compiler.Tests
 
         [Fact]
         [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/50879", TestPlatforms.Android)]
         public void MetadataAttributes()
         {
             using (new ThreadCultureChange(CultureInfo.InvariantCulture))
@@ -1469,7 +1468,6 @@ namespace System.CodeDom.Compiler.Tests
 
         [Fact]
         [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/50879", TestPlatforms.Android)]
         public void RegionsSnippetsAndLinePragmas()
         {
             using (new ThreadCultureChange(CultureInfo.InvariantCulture))
@@ -2590,7 +2588,6 @@ namespace System.CodeDom.Compiler.Tests
 
         [Fact]
         [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/50879", TestPlatforms.Android)]
         public void ProviderSupports()
         {
             using (new ThreadCultureChange(CultureInfo.InvariantCulture))
diff --git a/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/VBCodeGenerationTests.cs b/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/VBCodeGenerationTests.cs
index 06a31a17c32557240c4fd10d86e8fb236467b143..2abddb449d7ce2478f6488e654f0e2b4a2b61657 100644 (file)
--- a/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/VBCodeGenerationTests.cs
+++ b/src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/VBCodeGenerationTests.cs
@@ -580,7 +580,6 @@ namespace System.CodeDom.Compiler.Tests
 
         [Fact]
         [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/50879", TestPlatforms.Android)]
         public void MetadataAttributes()
         {
             using (new ThreadCultureChange(CultureInfo.InvariantCulture))
@@ -1400,7 +1399,6 @@ namespace System.CodeDom.Compiler.Tests
 
         [Fact]
         [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/50879", TestPlatforms.Android)]
         public void RegionsSnippetsAndLinePragmas()
         {
             using (new ThreadCultureChange(CultureInfo.InvariantCulture))
@@ -2362,7 +2360,6 @@ namespace System.CodeDom.Compiler.Tests
 
         [Fact]
         [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/50879", TestPlatforms.Android)]
         public void ProviderSupports()
         {
             using (new ThreadCultureChange(CultureInfo.InvariantCulture))
Domain: Dotnet / Core;