ACPI: scan: initialize local variable to avoid garbage being returned
authorColin Ian King <colin.king@canonical.com>
Wed, 9 Jun 2021 17:33:12 +0000 (18:33 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 10 Jun 2021 13:13:26 +0000 (15:13 +0200)
In the unlikely event that there are no callback calls made in
acpi_walk_dep_device_list(), local variable ret will be returned as
an uninitialized value.

Clean up static analysis warnings by ensuring ret is initialized.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: a9e10e587304 ("ACPI: scan: Extend acpi_walk_dep_device_list()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Daniel Scally <djrscally@gmail.com>
[ rjw: Subject and changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/scan.c

index 708c1d8..f64119a 100644 (file)
@@ -2150,7 +2150,7 @@ int acpi_walk_dep_device_list(acpi_handle handle,
                              void *data)
 {
        struct acpi_dep_data *dep, *tmp;
-       int ret;
+       int ret = 0;
 
        mutex_lock(&acpi_dep_list_lock);
        list_for_each_entry_safe(dep, tmp, &acpi_dep_list, node) {