projects
/
platform
/
kernel
/
linux-amlogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
6ca9fed
)
scsi: aha152x: Use DECLARE_COMPLETION_ONSTACK for non-constant completion
author
Zhongqiu Han
<quic_zhonhan@quicinc.com>
Fri, 5 Jul 2024 10:36:14 +0000
(18:36 +0800)
committer
Martin K. Petersen
<martin.petersen@oracle.com>
Thu, 11 Jul 2024 02:51:44 +0000
(22:51 -0400)
The _ONSTACK variant should be used for on-stack completion, otherwise it
will break lockdep. See also commit
6e9a4738c9fa
("[PATCH] completions:
lockdep annotate on stack completions").
Signed-off-by: Zhongqiu Han <quic_zhonhan@quicinc.com>
Link:
https://lore.kernel.org/r/20240705103614.3650637-1-quic_zhonhan@quicinc.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/aha152x.c
patch
|
blob
|
history
diff --git
a/drivers/scsi/aha152x.c
b/drivers/scsi/aha152x.c
index 83f16fc14d96307acdf431cfff922a3e5092443d..a0fb330b8df54a14bac64edc5e26d4a37d41b7df 100644
(file)
--- a/
drivers/scsi/aha152x.c
+++ b/
drivers/scsi/aha152x.c
@@
-1072,7
+1072,7
@@
static int aha152x_abort(struct scsi_cmnd *SCpnt)
static int aha152x_device_reset(struct scsi_cmnd * SCpnt)
{
struct Scsi_Host *shpnt = SCpnt->device->host;
- DECLARE_COMPLETION(done);
+ DECLARE_COMPLETION
_ONSTACK
(done);
int ret, issued, disconnected;
unsigned char old_cmd_len = SCpnt->cmd_len;
unsigned long flags;