drivers: media: imx708: Remove unused control fields
authorNaushir Patuck <naush@raspberrypi.com>
Fri, 31 Mar 2023 09:07:26 +0000 (10:07 +0100)
committerDom Cobley <popcornmix@gmail.com>
Mon, 19 Feb 2024 11:33:30 +0000 (11:33 +0000)
Remove unused and redundant control fields from the state structure.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
drivers/media/i2c/imx708.c

index a5d4882..1181c50 100644 (file)
@@ -825,9 +825,6 @@ struct imx708 {
        struct v4l2_ctrl *hflip;
        struct v4l2_ctrl *vblank;
        struct v4l2_ctrl *hblank;
-       struct v4l2_ctrl *red_balance;
-       struct v4l2_ctrl *blue_balance;
-       struct v4l2_ctrl *notify_gains;
        struct v4l2_ctrl *hdr_mode;
        struct v4l2_ctrl *link_freq;
 
@@ -1205,12 +1202,12 @@ static int imx708_set_ctrl(struct v4l2_ctrl *ctrl)
        case V4L2_CID_NOTIFY_GAINS:
                ret = imx708_write_reg(imx708, IMX708_REG_COLOUR_BALANCE_BLUE,
                                       IMX708_REG_VALUE_16BIT,
-                                      imx708->notify_gains->p_new.p_u32[0]);
+                                      ctrl->p_new.p_u32[0]);
                if (ret)
                        break;
                ret = imx708_write_reg(imx708, IMX708_REG_COLOUR_BALANCE_RED,
                                       IMX708_REG_VALUE_16BIT,
-                                      imx708->notify_gains->p_new.p_u32[3]);
+                                      ctrl->p_new.p_u32[3]);
                break;
        case V4L2_CID_WIDE_DYNAMIC_RANGE:
                /* Already handled above. */
@@ -1842,8 +1839,7 @@ static int imx708_init_controls(struct imx708 *imx708)
                /* The "Solid color" pattern is white by default */
        }
 
-       imx708->notify_gains = v4l2_ctrl_new_custom(ctrl_hdlr,
-                                                   &imx708_notify_gains_ctrl, NULL);
+       v4l2_ctrl_new_custom(ctrl_hdlr, &imx708_notify_gains_ctrl, NULL);
 
        imx708->hdr_mode = v4l2_ctrl_new_std(ctrl_hdlr, &imx708_ctrl_ops,
                                             V4L2_CID_WIDE_DYNAMIC_RANGE,