hwmon: (adt7470) Fix some style issues
authorChris Packham <chris.packham@alliedtelesis.co.nz>
Thu, 26 Aug 2021 02:41:18 +0000 (14:41 +1200)
committerGuenter Roeck <linux@roeck-us.net>
Fri, 27 Aug 2021 21:13:20 +0000 (14:13 -0700)
In preparation for the changes that follow fix up some existing style
issues.
Specifically:
- add blank line between variable declaration and code
- use strscpy instead of strlcpy
- remove unnecessary braces

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Link: https://lore.kernel.org/r/20210826024121.15665-2-chris.packham@alliedtelesis.co.nz
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/adt7470.c

index 2e8feac..3358ec5 100644 (file)
@@ -174,6 +174,7 @@ struct adt7470_data {
 static inline int adt7470_read_word_data(struct i2c_client *client, u8 reg)
 {
        u16 foo;
+
        foo = i2c_smbus_read_byte_data(client, reg);
        foo |= ((u16)i2c_smbus_read_byte_data(client, reg + 1) << 8);
        return foo;
@@ -1282,7 +1283,7 @@ static int adt7470_detect(struct i2c_client *client,
        if (revision != ADT7470_REVISION)
                return -ENODEV;
 
-       strlcpy(info->type, "adt7470", I2C_NAME_SIZE);
+       strscpy(info->type, "adt7470", I2C_NAME_SIZE);
 
        return 0;
 }
@@ -1331,9 +1332,8 @@ static int adt7470_probe(struct i2c_client *client)
 
        data->auto_update = kthread_run(adt7470_update_thread, client, "%s",
                                        dev_name(hwmon_dev));
-       if (IS_ERR(data->auto_update)) {
+       if (IS_ERR(data->auto_update))
                return PTR_ERR(data->auto_update);
-       }
 
        return 0;
 }