usb: typec: anx7411: fix passing zero to 'PTR_ERR'
authorXin Ji <xji@analogixsemi.com>
Fri, 22 Jul 2022 08:18:34 +0000 (16:18 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 Jul 2022 12:28:07 +0000 (14:28 +0200)
Fix anx7411_register_partner() warn: passing zero to 'PTR_ERR'

Fixes: fe6d8a9c8e64 ("usb: typec: anx7411: Add Analogix PD ANX7411 support")
Signed-off-by: Xin Ji <xji@analogixsemi.com>
Link: https://lore.kernel.org/r/20220722081836.3380885-1-xji@analogixsemi.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/anx7411.c

index f8baa1e..c0f0842 100644 (file)
@@ -374,6 +374,7 @@ static int anx7411_register_partner(struct anx7411_data *ctx,
                                    int pd, int accessory)
 {
        struct typec_partner_desc desc;
+       struct typec_partner *partner;
 
        if (ctx->typec.partner)
                return 0;
@@ -381,11 +382,11 @@ static int anx7411_register_partner(struct anx7411_data *ctx,
        desc.usb_pd = pd;
        desc.accessory = accessory;
        desc.identity = NULL;
-       ctx->typec.partner = typec_register_partner(ctx->typec.port, &desc);
-       if (IS_ERR(ctx->typec.partner)) {
-               ctx->typec.partner = NULL;
-               return PTR_ERR(ctx->typec.partner);
-       }
+       partner = typec_register_partner(ctx->typec.port, &desc);
+       if (IS_ERR(partner))
+               return PTR_ERR(partner);
+
+       ctx->typec.partner = partner;
 
        return 0;
 }