python-smartpm: fix option typo of command channel
authorKai Kang <kai.kang@windriver.com>
Wed, 30 Jul 2014 06:26:27 +0000 (14:26 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 2 Aug 2014 08:26:14 +0000 (09:26 +0100)
When run smart, it fails:

root@qemu1:~# smart channel --remove-all
error: No action specified for command 'channel'

If no default value of arg 'dest' is provided in method add_option() of
optparse.OptionParser, it replaces hyphen('-') in new added option with
underscore('_') as dest.

In function ensure_action() it checks action strings with options from
optparse.OptionParser. So it is 'remove_all' which need to be checked
rather than 'remove-all'.

(From OE-Core rev: 03266e89a67ec1373529fae32b2cedff21414ff5)

Signed-off-by: Kai Kang <kai.kang@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-devtools/python/python-smartpm/smart-improve-error-reporting.patch

index fece5b9..2ca0f6d 100644 (file)
@@ -24,7 +24,7 @@ index aa76f91..63fbb35 100644
 +    opts.check_args_of_option("edit", 0)
 +    opts.check_args_of_option("enable", -1)
 +    opts.check_args_of_option("disable", -1)
-+    opts.ensure_action("channel", ["add", "set", "remove", "remove-all",
++    opts.ensure_action("channel", ["add", "set", "remove", "remove_all",
 +                       "list", "show", "yaml", "enable", "disable"])
 +    opts.check_remaining_args()
 +