projects
/
platform
/
adaptation
/
renesas_rcar
/
renesas_kernel.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
716323c
)
Staging: rt2860: test off by one in RtmpAsicSendCommandToMcu()
author
Roel Kluin
<roel.kluin@gmail.com>
Sat, 26 Dec 2009 19:00:47 +0000
(20:00 +0100)
committer
Greg Kroah-Hartman
<gregkh@suse.de>
Thu, 4 Mar 2010 00:42:34 +0000
(16:42 -0800)
`i' reaches 101 after the loop, so if it was 100 then it succeeded in
the last iteration. This is probably unlikely to cause problems.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/rt2860/common/rtmp_mcu.c
patch
|
blob
|
history
diff --git
a/drivers/staging/rt2860/common/rtmp_mcu.c
b/drivers/staging/rt2860/common/rtmp_mcu.c
index
9f03901
..
e80f587
100644
(file)
--- a/
drivers/staging/rt2860/common/rtmp_mcu.c
+++ b/
drivers/staging/rt2860/common/rtmp_mcu.c
@@
-221,7
+221,7
@@
int RtmpAsicSendCommandToMcu(struct rt_rtmp_adapter *pAd,
("AsicSendCommanToMcu::Mail box is busy\n"));
} while (i++ < 100);
- if (i >
=
100) {
+ if (i > 100) {
DBGPRINT_ERR(("H2M_MAILBOX still hold by MCU. command fail\n"));
return FALSE;
}