[M108 Migration][MM] Ignore buffers if callback is null 62/288262/5
authorVenugopal S M <sm.venugopal@samsung.com>
Thu, 2 Jun 2022 17:27:51 +0000 (22:57 +0530)
committerBot Blink <blinkbot@samsung.com>
Wed, 15 Feb 2023 16:23:01 +0000 (16:23 +0000)
In "video_onended_event" for no reason, buffers are sent after EOS is
received. The read-calback is null and would crash.

Reference: https://review.tizen.org/gerrit/275840/

Change-Id: Icccfa6c6e35000c7993139077ade2817232051b5
Signed-off-by: Venugopal S M <sm.venugopal@samsung.com>
media/mojo/services/mojo_demuxer_stream_adapter.cc

index dcd0d90..0dcbb81 100644 (file)
@@ -95,6 +95,14 @@ void MojoDemuxerStreamAdapter::OnBufferReady(
   DCHECK(read_cb_);
   DCHECK_NE(type_, UNKNOWN);
 
+#if defined(TIZEN_MULTIMEDIA)
+  if (!read_cb_) {
+    LOG(INFO) << __func__ << " (" << DemuxerStream::GetTypeName(type_)
+              << ") ignoring as cb is null!!";
+    return;
+  }
+#endif
+
   if (status == kConfigChanged) {
     UpdateConfig(std::move(audio_config), std::move(video_config));
     std::move(read_cb_).Run(kConfigChanged, nullptr);