staging: wfx: check value of beacon_int
authorJérôme Pouiller <jerome.pouiller@silabs.com>
Fri, 10 Apr 2020 13:32:37 +0000 (15:32 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Apr 2020 12:42:50 +0000 (14:42 +0200)
Firmware dislike when beacon_int value is 0. This patch add some
warnings in case it would happen.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20200410133239.438347-18-Jerome.Pouiller@silabs.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wfx/hif_tx.c

index d44e5ca..f49ab67 100644 (file)
@@ -296,6 +296,7 @@ int hif_join(struct wfx_vif *wvif, const struct ieee80211_bss_conf *conf,
        struct hif_msg *hif;
        struct hif_req_join *body = wfx_alloc_hif(sizeof(*body), &hif);
 
+       WARN_ON(!conf->beacon_int);
        WARN_ON(!conf->basic_rates);
        WARN_ON(sizeof(body->ssid) < ssidlen);
        WARN(!conf->ibss_joined && !ssidlen, "joining an unknown BSS");
@@ -430,6 +431,7 @@ int hif_start(struct wfx_vif *wvif, const struct ieee80211_bss_conf *conf,
        struct hif_msg *hif;
        struct hif_req_start *body = wfx_alloc_hif(sizeof(*body), &hif);
 
+       WARN_ON(!conf->beacon_int);
        body->dtim_period = conf->dtim_period;
        body->short_preamble = conf->use_short_preamble;
        body->channel_number = cpu_to_le16(channel->hw_value);