rpmsg: glink: Initialize the "intent_req_comp" completion variable
authorArun Kumar Neelakantam <aneela@codeaurora.org>
Mon, 30 Oct 2017 05:41:24 +0000 (11:11 +0530)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Tue, 31 Oct 2017 02:00:25 +0000 (19:00 -0700)
The "intent_req_comp" variable is used without initialization which
results in NULL pointer dereference in qcom_glink_request_intent().

we need to initialize the completion variable before using it.

Fixes: 27b9c5b66b23 ("rpmsg: glink: Request for intents when unavailable")
Signed-off-by: Arun Kumar Neelakantam <aneela@codeaurora.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/rpmsg/qcom_glink_native.c

index 5dcc9bf..fcd46ab 100644 (file)
@@ -227,6 +227,7 @@ static struct glink_channel *qcom_glink_alloc_channel(struct qcom_glink *glink,
 
        init_completion(&channel->open_req);
        init_completion(&channel->open_ack);
+       init_completion(&channel->intent_req_comp);
 
        INIT_LIST_HEAD(&channel->done_intents);
        INIT_WORK(&channel->intent_work, qcom_glink_rx_done_work);