smb3: add one more dynamic tracepoint missing from strict fsync path
authorSteve French <stfrench@microsoft.com>
Thu, 6 Feb 2020 22:04:59 +0000 (16:04 -0600)
committerSteve French <stfrench@microsoft.com>
Thu, 6 Feb 2020 23:21:23 +0000 (17:21 -0600)
We didn't have a dynamic trace point for catching errors in
file_write_and_wait_range error cases in cifs_strict_fsync.

Since not all apps check for write behind errors, it can be
important for debugging to be able to trace these error
paths.

Suggested-and-reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/file.c

index 99ea7b2..bc9516a 100644 (file)
@@ -2593,8 +2593,10 @@ int cifs_strict_fsync(struct file *file, loff_t start, loff_t end,
        struct cifs_sb_info *cifs_sb = CIFS_SB(inode->i_sb);
 
        rc = file_write_and_wait_range(file, start, end);
-       if (rc)
+       if (rc) {
+               trace_cifs_fsync_err(inode->i_ino, rc);
                return rc;
+       }
 
        xid = get_xid();