Remove V8_USE_OLD_STYLE_PERSISTENT_HANDLE_VISITORS.

Blink has migrated to use the new style visitors.

BUG=
R=dcarney@chromium.org, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/16360005

Patch from Marja Hölttä <marja@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14936 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

diff --git a/include/v8.h b/include/v8.h
index a41445d..28a63f0 100644 (file)
--- a/include/v8.h
+++ b/include/v8.h
@@ -223,7 +223,6 @@ class WeakReferenceCallbacks {
 
 
 #define V8_USE_UNSAFE_HANDLES
-#define V8_USE_OLD_STYLE_PERSISTENT_HANDLE_VISITORS
 
 /**
  * An object reference managed by the v8 garbage collector.
@@ -4125,13 +4124,8 @@ class V8EXPORT ExternalResourceVisitor {  // NOLINT
 class V8EXPORT PersistentHandleVisitor {  // NOLINT
  public:
   virtual ~PersistentHandleVisitor() {}
-#ifdef V8_USE_OLD_STYLE_PERSISTENT_HANDLE_VISITORS
-  virtual void VisitPersistentHandle(Persistent<Value> value,
-                                     uint16_t class_id) {}
-#else
   virtual void VisitPersistentHandle(Persistent<Value>* value,
                                      uint16_t class_id) {}
-#endif
 };
 
 

diff --git a/src/api.cc b/src/api.cc
index 9556b69..5b6b644 100644 (file)
--- a/src/api.cc
+++ b/src/api.cc
@@ -5087,14 +5087,9 @@ class VisitorAdapter : public i::ObjectVisitor {
     UNREACHABLE();
   }
   virtual void VisitEmbedderReference(i::Object** p, uint16_t class_id) {
-#ifdef V8_USE_OLD_STYLE_PERSISTENT_HANDLE_VISITORS
-    visitor_->VisitPersistentHandle(ToApi<Value>(i::Handle<i::Object>(p)),
-                                    class_id);
-#else
     Value* value = ToApi<Value>(i::Handle<i::Object>(p));
     visitor_->VisitPersistentHandle(
         reinterpret_cast<Persistent<Value>*>(&value), class_id);
-#endif
   }
  private:
   PersistentHandleVisitor* visitor_;

diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index b88eedf..cb3a38e 100644 (file)
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -17537,13 +17537,6 @@ class Visitor42 : public v8::PersistentHandleVisitor {
   explicit Visitor42(v8::Persistent<v8::Object>* object)
       : counter_(0), object_(object) { }
 
-#ifdef V8_USE_OLD_STYLE_PERSISTENT_HANDLE_VISITORS
-  virtual void VisitPersistentHandle(Persistent<Value> value,
-                                     uint16_t class_id) {
-    VisitPersistentHandle(&value, class_id);
-  }
-#endif
-
   virtual void VisitPersistentHandle(Persistent<Value>* value,
                                      uint16_t class_id) {
     if (class_id != 42) return;