drm/amd/display: Reduce SCDC Status Flags Definition
authorChris Park <chris.park@amd.com>
Thu, 23 Jun 2022 22:21:59 +0000 (18:21 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 13 Jul 2022 15:25:16 +0000 (11:25 -0400)
[Why]
Status flags definition is reduced to read
less bytes in SCDC transaction for status update.

[How]
Reduce definition of reserved bytes from 3 to 1
for status update.

Reviewed-by: Charlene Liu <Charlene.Liu@amd.com>
Acked-by: Solomon Chiu <solomon.chiu@amd.com>
Signed-off-by: Chris Park <chris.park@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c

index b13a516..d01d2ee 100644 (file)
@@ -93,16 +93,13 @@ union hdmi_scdc_update_read_data {
 };
 
 union hdmi_scdc_status_flags_data {
-       uint8_t byte[2];
+       uint8_t byte;
        struct {
                uint8_t CLOCK_DETECTED:1;
                uint8_t CH0_LOCKED:1;
                uint8_t CH1_LOCKED:1;
                uint8_t CH2_LOCKED:1;
                uint8_t RESERVED:4;
-               uint8_t RESERVED2:8;
-               uint8_t RESERVED3:8;
-
        } fields;
 };
 
@@ -770,7 +767,7 @@ void dal_ddc_service_read_scdc_data(struct ddc_service *ddc_service)
                                sizeof(scramble_status));
                offset = HDMI_SCDC_STATUS_FLAGS;
                dal_ddc_service_query_ddc_data(ddc_service, slave_address,
-                               &offset, sizeof(offset), status_data.byte,
+                               &offset, sizeof(offset), &status_data.byte,
                                sizeof(status_data.byte));
        }
 }