Use auto reference for static analysis warnings (#12472)

This will revise to use auto reference to fix static analysis warnings.

ONE-DCO-1.0-Signed-off-by: SaeHie Park <saehie.park@gmail.com>

diff --git a/compiler/luci/export/src/CircleExportMetadata.cpp b/compiler/luci/export/src/CircleExportMetadata.cpp
index 017002f5c84cf0855b61e57fa247c46d109ff7d8..25d0168ec1c23e6460bf0fb6a96f7aad89777379 100644 (file)
--- a/compiler/luci/export/src/CircleExportMetadata.cpp
+++ b/compiler/luci/export/src/CircleExportMetadata.cpp
@@ -56,7 +56,7 @@ const std::vector<uint8_t> CircleExportMetadata::encoded_execution_plan_table()
     const auto id = kv.first;
     write_u32(data, id);
 
-    const auto plan_vector = kv.second;
+    const auto &plan_vector = kv.second;
     const auto size = plan_vector.size();
     write_u32(data, size);
 
@@ -81,7 +81,7 @@ const std::vector<uint8_t> CircleExportMetadata::encoded_source_table(void)
     const auto id = kv.first;
     write_u32(data, id);
 
-    const auto origin_name = kv.second;
+    const auto &origin_name = kv.second;
     const auto length = origin_name.length();
     write_u32(data, length + 1); // name + '\0
 
@@ -107,7 +107,7 @@ const std::vector<uint8_t> CircleExportMetadata::encoded_op_table(void)
     const auto id = kv.first;
     write_u32(data, id);
 
-    const auto origins = kv.second;
+    const auto &origins = kv.second;
     const auto node_num = origins.size();
     write_u32(data, node_num);
 

diff --git a/compiler/luci/import/src/CircleImportMetadata.cpp b/compiler/luci/import/src/CircleImportMetadata.cpp
index 9c1fe73560613563c685a6e8d4914fdb57b85d4f..fbdea8a7c2992589e8b9045569d4296dbe9f3aa1 100644 (file)
--- a/compiler/luci/import/src/CircleImportMetadata.cpp
+++ b/compiler/luci/import/src/CircleImportMetadata.cpp
@@ -236,7 +236,7 @@ const OriginTable CircleImportMetadata::origin_table(void)
       std::vector<std::shared_ptr<CircleNodeOrigin>> origins;
       for (auto source_id : source_ids)
       {
-        const auto source_name = _source_table.at(source_id);
+        const auto &source_name = _source_table.at(source_id);
         origins.push_back(single_origin(source_id, source_name));
       }
 

diff --git a/compiler/luci/partition/src/PartitionIRDump.cpp b/compiler/luci/partition/src/PartitionIRDump.cpp
index 0fabfc416e10e02e83c5caa0dd5476e41dcce2ad..5a78d99c085ed7af7995e9755e72b87fc4185bb4 100644 (file)
--- a/compiler/luci/partition/src/PartitionIRDump.cpp
+++ b/compiler/luci/partition/src/PartitionIRDump.cpp
@@ -56,7 +56,7 @@ void dump(std::ostream &os, const PGroups *pgroups)
   for (auto it = pgroups->node2group.begin(); it != pgroups->node2group.end(); ++it)
   {
     auto node = it->first;
-    auto group = it->second;
+    auto &group = it->second;
     os << "  Node: " << node << "(" << luci::opcode_name(node) << "," << node->name()
        << "): " << group << std::endl;
   }

diff --git a/compiler/luci/pass/src/CircleQuantizer.cpp b/compiler/luci/pass/src/CircleQuantizer.cpp
index 9039a839f1a911ce68bca43cd9a14e325b104298..6db26d179a78e7fff1aed84de9e2a28e11f969e1 100644 (file)
--- a/compiler/luci/pass/src/CircleQuantizer.cpp
+++ b/compiler/luci/pass/src/CircleQuantizer.cpp
@@ -352,7 +352,7 @@ void CircleQuantizer::quantize(loco::Graph *g) const
     // Check dtype/granularity of layer params
     for (auto layer_param : layer_params)
     {
-      auto name = layer_param->name;
+      const auto &name = layer_param->name;
       if (!in_array(to_lower_case(layer_param->dtype), fakeq_supported_output_model_dtype))
       {
         throw std::runtime_error("Unsupported dtype in " + name + ". List of supported dtype: " +

diff --git a/compiler/luci/pass/src/CopyQuantParamPass.cpp b/compiler/luci/pass/src/CopyQuantParamPass.cpp
index 9b1bb0ea902294469d59316d5fc22b21c77a369d..0984fe85c79e175e52186a7929a8898ebb9c27a8 100644 (file)
--- a/compiler/luci/pass/src/CopyQuantParamPass.cpp
+++ b/compiler/luci/pass/src/CopyQuantParamPass.cpp
@@ -59,8 +59,8 @@ bool CopyQuantParamPass::run(loco::Graph *g)
 
   for (uint32_t i = 0; i < _src_tensors.size(); i++)
   {
-    auto src = _src_tensors[i];
-    auto dst = _dst_tensors[i];
+    auto &src = _src_tensors[i];
+    auto &dst = _dst_tensors[i];
 
     auto nodes = get_src_dst(src, dst);
     if (not nodes.src)

diff --git a/compiler/luci/pass/src/SubstituteSqueezeToReshapePass.cpp b/compiler/luci/pass/src/SubstituteSqueezeToReshapePass.cpp
index df7266df950431da3cfc918a58e73d263faf02ad..9bc764f92ece9ec6942d72b11b138e29e60535c0 100644 (file)
--- a/compiler/luci/pass/src/SubstituteSqueezeToReshapePass.cpp
+++ b/compiler/luci/pass/src/SubstituteSqueezeToReshapePass.cpp
@@ -119,7 +119,7 @@ bool substitute_squeeze_to_reshape(luci::CircleSqueeze *squeeze)
   if (squeeze->shape_status() != luci::ShapeStatus::VALID)
     return false;
 
-  auto squeeze_dims = squeeze->squeeze_dims();
+  auto &squeeze_dims = squeeze->squeeze_dims();
   if (not is_valid_input(input, squeeze_dims))
     throw std::runtime_error("Invalid values in squeeze_dims: " + squeeze->name());
 

diff --git a/compiler/luci/pass/src/helpers/LayerInfoMap.cpp b/compiler/luci/pass/src/helpers/LayerInfoMap.cpp
index ac07f9ec9ba1e7b236233737cd112c897c3c4028..37d8e18e9b0e782e020943a703fd08ddc64dcb25 100644 (file)
--- a/compiler/luci/pass/src/helpers/LayerInfoMap.cpp
+++ b/compiler/luci/pass/src/helpers/LayerInfoMap.cpp
@@ -145,7 +145,7 @@ LayerInfoMap layer_info_map(loco::Graph *g, std::vector<LayerInfo> &layers_info)
 
   for (auto &&info : layers_info)
   {
-    auto name = info.name;
+    auto &name = info.name;
     bool found = false;
     for (auto node : loco::active_nodes(loco::output_nodes(g)))
     {

diff --git a/compiler/luci/service/src/ChangeOutputs.cpp b/compiler/luci/service/src/ChangeOutputs.cpp
index 1f80000619d917cc5294a5f99a09a8e12fc5b92a..65175530c9f48e5e0bf65f2fec12c60ce11c3d51 100644 (file)
--- a/compiler/luci/service/src/ChangeOutputs.cpp
+++ b/compiler/luci/service/src/ChangeOutputs.cpp
@@ -72,7 +72,7 @@ void change_outputs(loco::Graph *graph, const std::vector<std::string> &new_outp
     auto output = luci::output_node(graph, out); // output is CircleOutput
     assert(output != nullptr);
 
-    auto node_name = new_outputs.at(out);
+    auto &node_name = new_outputs.at(out);
     auto node = named_nodes[node_name];
     assert(node != nullptr);
 

diff --git a/compiler/luci/service/src/ShapeInfer_StridedSlice.cpp b/compiler/luci/service/src/ShapeInfer_StridedSlice.cpp
index 33490db1962f60a3a5a73c9202cd9e97b061fd57..5a22da3198cdb59d62639e05485cd95cf2601300 100644 (file)
--- a/compiler/luci/service/src/ShapeInfer_StridedSlice.cpp
+++ b/compiler/luci/service/src/ShapeInfer_StridedSlice.cpp
@@ -398,7 +398,7 @@ loco::TensorShape infer_output_shape(const CircleStridedSlice *node)
 
   StridedSliceContext op_context(node);
   auto op_params = BuildStridedSliceParams(&op_context);
-  auto effective_input_shape = op_context.effective_input_shape;
+  auto &effective_input_shape = op_context.effective_input_shape;
   std::vector<int64_t> output_shape_vector;
 
   for (int32_t idx = effective_input_shape.rank() - 1; idx >= 0; --idx)