ceph: unlock on error in ceph_osdc_start_request()
authorDan Carpenter <error27@gmail.com>
Tue, 29 Mar 2011 03:25:59 +0000 (06:25 +0300)
committerSage Weil <sage@newdream.net>
Tue, 29 Mar 2011 15:59:54 +0000 (08:59 -0700)
There was a missing unlock on the error path if __map_request() failed.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Sage Weil <sage@newdream.net>
net/ceph/osd_client.c

index b6776cb..03740e8 100644 (file)
@@ -1672,7 +1672,7 @@ int ceph_osdc_start_request(struct ceph_osd_client *osdc,
        if (req->r_sent == 0) {
                rc = __map_request(osdc, req);
                if (rc < 0)
-                       return rc;
+                       goto out_unlock;
                if (req->r_osd == NULL) {
                        dout("send_request %p no up osds in pg\n", req);
                        ceph_monc_request_next_osdmap(&osdc->client->monc);
@@ -1689,6 +1689,8 @@ int ceph_osdc_start_request(struct ceph_osd_client *osdc,
                        }
                }
        }
+
+out_unlock:
        mutex_unlock(&osdc->request_mutex);
        up_read(&osdc->map_sem);
        return rc;